Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAT-4193a: Fixing WAF Intercept #108

Merged
merged 2 commits into from
Nov 7, 2024
Merged

MAT-4193a: Fixing WAF Intercept #108

merged 2 commits into from
Nov 7, 2024

Conversation

ethankaplan
Copy link
Contributor

MADiE PR

Jira Ticket: MAT-4193
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@ethankaplan ethankaplan requested a review from a team as a code owner November 7, 2024 18:03
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.49%. Comparing base (2cb5be3) to head (c57b90e).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #108   +/-   ##
========================================
  Coverage    60.49%   60.49%           
========================================
  Files           17       17           
  Lines          162      162           
  Branches        21       21           
========================================
  Hits            98       98           
  Misses          64       64

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sb-cecilialiu
sb-cecilialiu reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't pass git leak scan?

sb-cecilialiu
sb-cecilialiu previously requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@sb-cecilialiu sb-cecilialiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git leak scan didn't pass

@ethankaplan ethankaplan dismissed sb-cecilialiu’s stale review November 7, 2024 18:31

Works now, it seems

@ethankaplan ethankaplan merged commit 805868e into develop Nov 7, 2024
15 checks passed
@ethankaplan ethankaplan deleted the MAT-4193a branch November 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sb-cecilialiu sb-cecilialiu sb-cecilialiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethankaplan @sb-cecilialiu